Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve custom url backend #499

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Improve custom url backend #499

merged 3 commits into from
Nov 3, 2021

Conversation

magnusrand
Copy link
Contributor

@magnusrand magnusrand commented Oct 21, 2021

Denne PRen forbedrer funksjonaliteten til egendefinert URL ved hjelp av to endringer:

  • Det er nå mulig å sette tavla si til en URL som eksisterer, men er satt med isScheduledForDelete === true. Dette ga før en feilmelding om at denne url-en ikke er tilgjengelig. Når man gjør dette slettes den tavla som har url-en man ønsker med en gang før man lager en kopi av nåværende tavle med den nye urlen og setter gamle til isScheduledForDelete = true.
  • I Mine tavler vises nå ikke lenger tavler som har isScheduledForDelete === true lenger. Dette gjør at man ikke lenger får duplikater i listen.

@magnusrand magnusrand requested a review from a team October 21, 2021 12:32
@magnusrand magnusrand marked this pull request as draft October 21, 2021 12:32
@magnusrand magnusrand marked this pull request as ready for review October 21, 2021 12:33
src/services/firebase.ts Outdated Show resolved Hide resolved
src/settings/index.ts Outdated Show resolved Hide resolved
src/containers/MyBoards/index.tsx Outdated Show resolved Hide resolved
src/settings/index.ts Outdated Show resolved Hide resolved
@magnusrand magnusrand merged commit 3e33631 into master Nov 3, 2021
@magnusrand magnusrand deleted the improve-custom-url-backend branch November 3, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants