Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚲 Bike station migration 🚲 : Moving to mobility API (v2) #470

Merged
merged 17 commits into from
Sep 22, 2021
Merged

🚲 Bike station migration 🚲 : Moving to mobility API (v2) #470

merged 17 commits into from
Sep 22, 2021

Commits on Sep 15, 2021

  1. Upgraded @entur/sdk package to 4.2.0

    @bendiksk
    bendiksk committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    4b3d588 View commit details
    Browse the repository at this point in the history

  2. WIP: Changed bikeStations hook to use mobilityV2 api

    @bendiksk
    bendiksk committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    78096f3 View commit details
    Browse the repository at this point in the history

  3. WIP: Migrated from type BikeRentalStation to Station.. 

    * Part of the migration to use mobility v2 api to fetch bike rental stations
* The new API returns data of the type Station, with different properties
    @bendiksk
    bendiksk committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    8842814 View commit details
    Browse the repository at this point in the history

  4. WIP: Implemented getTranslation utility function 

    * .. to be used with objects of the TranslatedString type from entur/sdk
* enables easier language-change if future translations are added to the API
    @bendiksk
    bendiksk committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    ba7efff View commit details
    Browse the repository at this point in the history

  5. WIP: Migrating useBikeRentalStation 

    Fixed render loop in useEffect
    @bendiksk
    bendiksk committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    4c66347 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. WIP: Migrating useBikeRentalStations 

    * Fixed missing bike-tile
* Refactored useEffect into smaller responsibilities
    @bendiksk
    bendiksk committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    74e540c View commit details
    Browse the repository at this point in the history

  2. WIP: migrating to useBikeRentalStations 

    Changed implementation to use custom useBikeRentalStations hook in EditTab
    @bendiksk
    bendiksk committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    9c19bfc View commit details
    Browse the repository at this point in the history

  3. WIP: migrating to new bike rental stations in BikeSearch 

    * Migrating to fetch from mobility API v2 in BikeSearch
* Type migration BikeRentalStation -> Station
    @bendiksk
    bendiksk committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    1c114ac View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. Refactor: Renamed exported component in StopPlaceSearch to match file… 

    …name
    @bendiksk
    bendiksk committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    4c22d57 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. WIP: migrating useBikeRentalStations 

    * added argument removeHiddenStations which may be set to false to enable usability for EditTab where hidden stations is needed in toggle-list
* fixed filtering logic in hook (removed adding of duplicate stations)
    @bendiksk
    bendiksk committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    f427607 View commit details
    Browse the repository at this point in the history

  2. Refactor: Moved utility function includesStation() to utils.tsx

    @bendiksk
    bendiksk committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    7a5c380 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into mobility-v2-stations

    @bendiksk
    bendiksk committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    c14b1d2 View commit details
    Browse the repository at this point in the history

  4. Fix: Disabled ability to add duplicate stations 

    * Fixed conditionless adding of bike rental station added through search field. Now checks if ID is already stored in settings.newStations
    @bendiksk
    bendiksk committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    b5011ef View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2021

  1. Refactor: Moved includesStation() logic inline 

    * Removed includesStation() from utils.tsx, implemented logic directly in useBikeRentalStation
    @bendiksk
    bendiksk committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    efdc81f View commit details
    Browse the repository at this point in the history

  2. Removed unused import

    @bendiksk
    bendiksk committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    048e63e View commit details
    Browse the repository at this point in the history

  3. Refactor: Cleanup useEffects using AbortController 

    * Changed cleanups in useEffects (in EditTab/*) to use AbortController instead of primitive boolean variable
    @bendiksk
    bendiksk committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    5f583ae View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. Fixed defaults when missing station name in EditTab/ 

    * Default to empty string '' instead of station.id
* Sorting station names defaults to putting stations with missing name last
    @bendiksk
    bendiksk committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    bf58e02 View commit details
    Browse the repository at this point in the history