Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiks «A component is changing an uncontrolled input of type checkbox to be controlled.»-feil i Admin-panelet #469

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

magnusrand
Copy link
Contributor

Denne PRen fikser en feil i Admin-panelet der innstillings-tilen for vær og kart ikke har en satt startverdi når de hentes fra settings. Dette gjør at form-komponenten starter som uncontrolled for så å bli controlled., noe React ikke liker (https://reactjs.org/docs/forms.html#controlled-components). Fiksen er så enkel som at showMap og showWeather settes default til false hvis verdien deres ikke er satt i settings.

@magnusrand magnusrand requested a review from a team September 20, 2021 08:49
@magnusrand magnusrand merged commit cdccfb4 into master Sep 20, 2021
@magnusrand magnusrand deleted the fix/uncontroller-form-error branch September 20, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants