Fikse uendelig loop i useeffekten til holdeplass-view #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draperunner
reviewed
Sep 2, 2021
draperunner
approved these changes
Sep 3, 2021
bendiksk
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slik jeg har skjønt det fører den if-en fra 118 til 123 til at
stopPlacesWithDeparturesble forskjellig på hver render. Det førte til at loopen ble uendelig om ikke ifen 152 til 154 kicket inn og hindret at noe state ble satt i useeffecten. Endret derfor til å kjøre filtreringen inni useeffecten. Jeg gjorde noen andre refactoringer her som jeg synes ga mening. Åpen for innspill om det er noe en er uenig i.