Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(edit): move board between organizations and personal boards #1537

Merged
merged 13 commits into from
Jun 21, 2024
Merged

feat(edit): move board between organizations and personal boards #1537

merged 13 commits into from
Jun 21, 2024

Conversation

oyvindgrutle
Copy link
Collaborator

image

emilielr
emilielr requested changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@emilielr emilielr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eneste jeg tenkte på var om det burde være en dropdown-option for å ikke velge organisasjon? jeg vet ikke helt om det er intuitivt at når det er blankt, så betyr det at den legges privat. med nye tavler nå, så vil de som ikke har en organisasjon stå "privat" på, så det kan være en ide at et dropdown-option er det - om ikke kan vi prøve med blankt. evt hør med hannah.

ellers; works like a charm 🚀

next-tavla/app/(admin)/hooks/useOrganizations.ts Outdated Show resolved Hide resolved
next-tavla/app/(admin)/edit/[id]/components/MetaSettings/index.tsx Show resolved Hide resolved
@oyvindgrutle oyvindgrutle requested a review from emilielr June 4, 2024 07:18
@emilielr
Copy link
Collaborator

emilielr commented Jun 4, 2024

Hvis man ikke huker av for personlig tavle, eller har valgt organisasjon, så får man opp en toaster og man blir redirecta til forsiden. Går man inn på tavler-siden igjen, så er tavlen borte. Den ligger fortsatt under boards-collection i Firebase, men tavle-iden ligger verken på brukeren eller i en organisasjon. Bør legge til en sjekk som sjekker om enten "Privat tavle" eller en organisasjon er valgt for at man skal kunne lagre.

@oyvindgrutle oyvindgrutle requested review from emilielr and removed request for emilielr June 4, 2024 15:52
lindtvedtsebastian
lindtvedtsebastian suggested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@lindtvedtsebastian lindtvedtsebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prøv med to funksjoner: en for privat og en for org, tror ting blir litt ryddigere da 🚀

next-tavla/app/(admin)/edit/[id]/components/MetaSettings/actions.ts Outdated Show resolved Hide resolved
@oyvindgrutle oyvindgrutle requested review from lindtvedtsebastian and removed request for lindtvedtsebastian June 11, 2024 11:02
@oyvindgrutle oyvindgrutle merged commit ebd2730 into master Jun 21, 2024
3 checks passed
@oyvindgrutle oyvindgrutle deleted the move-board branch June 21, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purusott purusott purusott approved these changes

@lindtvedtsebastian lindtvedtsebastian lindtvedtsebastian approved these changes

@emilielr emilielr emilielr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oyvindgrutle @emilielr @lindtvedtsebastian @purusott