Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move docker build to github workflow #246

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Move docker build to github workflow #246

merged 5 commits into from
Sep 11, 2023

Conversation

testower
Copy link
Collaborator

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@testower testower merged commit 7b526c1 into master Sep 11, 2023
4 checks passed
@testower testower deleted the github-action branch September 11, 2023 08:22
@testower testower mentioned this pull request Sep 11, 2023
@derhuerst
Copy link
Contributor

Note that the Docker image, as currently built by Jib, lacks the following:

  • a README.md, which Docker Hub would pick up and render
  • OCI image annotations like org.opencontainers.image.documentation or org.opencontainers.image.licenses, which various Docker-related tools read and display to provide a better DX

@testower
Copy link
Collaborator Author

Note that the Docker image, as currently built by Jib, lacks the following:

  • a README.md, which Docker Hub would pick up and render
  • OCI image annotations like org.opencontainers.image.documentation or org.opencontainers.image.licenses, which various Docker-related tools read and display to provide a better DX

Thanks, could you add this comment to #249 - I'll look into it there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants