Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for the unhappy path of signing #150

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Conversation

dvdplm
Copy link
Contributor

@dvdplm dvdplm commented Sep 25, 2024

I noticed that the test for the signing protocol does not traverse the unhappy path, where signature verification fails and we generate a correctness proof for the verifying signer. So here's a test for that along some more testing utils.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 98.16514% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.72%. Comparing base (13eec60) to head (c0ba441).

Files with missing lines Patch % Lines
synedrion/src/cggmp21/protocols/signing.rs 98.16% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   90.89%   92.72%   +1.82%     
==========================================
  Files          45       45              
  Lines        8162     8233      +71     
==========================================
+ Hits         7419     7634     +215     
+ Misses        743      599     -144     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dvdplm
Copy link
Contributor Author

dvdplm commented Sep 30, 2024

@fjarri A review on this would be nice, so we can get rid of CI failures due to missing coverage.

@fjarri
Copy link
Member

fjarri commented Oct 17, 2024

This may have to be modified when #151 lands, but it's a good test for now.

@fjarri fjarri merged commit 9e24b37 into master Oct 17, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
@fjarri fjarri deleted the dp-test-cheating-signer branch October 18, 2024 00:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants