Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have several different situations where we need to build on top of an existing protocol or combine several of them:
Round::Protocol
the same. This is useful for writing tests.Status
Misbehave
. Override macro and its machinery can be removed fromtesting
. ShouldMisbehave
go intotesting
? Or gated behind thetesting
feature?Chain
, but needs work on round nesting.Notes:
Protocol
implementation.Deserializer
. ShouldObjectSafeRound
make_*
methods take the deserializer too?