Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less bounds #53

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Less bounds #53

merged 2 commits into from
Oct 30, 2024

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Oct 30, 2024

Remove some unneeded Debug and 'static bounds

@fjarri fjarri marked this pull request as ready for review October 30, 2024 05:40
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11587692487

Details

  • 2 of 9 (22.22%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.149%

Changes Missing Coverage Covered Lines Changed/Added Lines %
manul/src/session/evidence.rs 0 7 0.0%
Totals Coverage Status
Change from base Build 11587383003: 0.0%
Covered Lines: 1474
Relevant Lines: 2043

💛 - Coveralls

@fjarri fjarri merged commit c960b6c into entropyxyz:master Oct 30, 2024
8 checks passed
@fjarri fjarri deleted the less-bounds branch October 30, 2024 05:47
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Just out of curiosity, does using #[derive_where::derive_where(Debug)] have any measurable impact at all on compile times?

@fjarri
Copy link
Member Author

fjarri commented Oct 30, 2024

I imagine there must be some difference, because the regular Debug derivation probably has some fast internal implementation, but I don't really see anything noticeable during recompilation. Besides the compilation of derive_more itself, of course, but that only happens once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants