Merge Signer
/Verifier
/Signature
/Digest
into SessionParameters
#36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly reduces the generics noise in the session layer, and also seems logical from the API perspective: signing types are basically a parameter supplied by the user to the session level. So
Digest
should be a part of them too, and not an associated type ofProtocol
.The second commit fixes #6. There is a very slight performance regression, about 2%, but I think it is worth it given the simplified API.
Also makes it much easier to implement #33 - so perhaps it should be redone after this goes in.