[NayNay] Entropy Register + Unit Tests #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added new register pure function - imported new types from sdk - added unit test for default register
Closed
mixmix
previously requested changes
Jul 16, 2024
There was a problem hiding this comment.
Looks good. Just one change requested
General reflections
- Love ❤️ 🔥 the simplicity and clarity of these pure functions. They're also easy to test = the right path
- The
flow/*/index.jsfunctions now start to feel like the same boiler plate 🗃️ 🥱 with many of them- take
configstate in, use config to startentropy - why? surely it should just take
entropyand that's all done a level higher for each flow
- take
Different PR tho (if that could even work .. it's late here)
|
@mixmix this PR is ready for re-review |
frankiebee
requested changes
Jul 16, 2024
Co-authored-by: Frankie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #149