Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize save_history_count to the default value of sv_save_history_count_archived #241

Merged

Conversation

1upD
Copy link

@1upD 1upD commented Nov 28, 2023

This is a fix for a case where the value of sv_save_history_count_archived has not yet been archived. When the game starts, it should copy the value of sv_save_history_count_archived into save_history_count. This might be the original, unarchived value. Once the value is archived, the callback in the ConVar will handle setting save_history_count.


PR Checklist

  • My PR follows all guidelines in the CONTRIBUTING.md file
  • My PR targets a develop branch OR targets another branch with a specific goal in mind

@1upD 1upD added the bug Something isn't working label Nov 28, 2023
@1upD 1upD requested a review from Blixibon November 28, 2023 03:46
@1upD 1upD self-assigned this Nov 28, 2023
@1upD 1upD merged commit 0c05054 into entropy-zero:ez2/mapbase Nov 28, 2023
5 checks passed
@1upD 1upD deleted the ez2/feature/initialize-save-history-count branch November 28, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants