Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split test_problems.py into test_*.py for each class #254

Merged
merged 4 commits into from
Jun 14, 2023

Conversation

Newtech66
Copy link
Contributor

@Newtech66 Newtech66 commented Jun 13, 2023

Description

  • Split test_problems.py into several test_*.py files which each contain the tests for a particular problem class.
  • Resolves Improve test_problems.py #226

Checklist

  • I have performed a self-review of my code.
  • I have commented my code and used numpy-style docstrings
  • I have made corresponding updates to the documentation.
  • My changes generate no new warnings
  • I have added/updated tests to make sure bugfix/feature works.
  • New and existing unit tests pass locally with my changes.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

PortfolioOptimization has been added to test_QUBO.py, but it doesn't pass on my system because the change to helper_functions.py isn't reflecting on the install for some reason.

@vishal-ph vishal-ph added the unitary_fund A feature supported by an UF grant label Jun 14, 2023
@vishal-ph
Copy link
Collaborator

@Newton66, can you please update your branch by pulling in the latest changes from dev. We realized there was an issue with the test_ext_dev action script that prevented the tests inside src/*/tests/ folders to run. We have fixed this in the latest commit on dev. Once you have pulled these changes, we can run the tests again

@Newtech66
Copy link
Contributor Author

@vishal-ph I did it

@vishal-ph
Copy link
Collaborator

@Newtech66, I cannot see the new changes on your branch yet, could you please merge the branch once more? Thanks

@vishal-ph
Copy link
Collaborator

The only test that failed in this PR was due to IBM account credentials being inaccessible by forked PRs. The PR is good to merge

@vishal-ph vishal-ph merged commit af96a54 into entropicalabs:dev Jun 14, 2023
@Newtech66 Newtech66 deleted the tp branch June 14, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unitary_fund A feature supported by an UF grant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants