Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add result statistics on measurement outcomes in QAOAResult object #252

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

TerraVenil
Copy link
Contributor

Description

This PR is for solving issue #235.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code and used numpy-style docstrings
  • I have made corresponding updates to the documentation.
  • My changes generate no new warnings
  • I have added/updated tests to make sure bugfix/feature works.
  • New and existing unit tests pass locally with my changes.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

test_qaoa_results_calculate_statistics_full, test_qaoa_results_calculate_statistics_without_intermediate, test_qaoa_results_calculate_statistics_raise_value_error.

@TerraVenil TerraVenil changed the base branch from main to dev June 10, 2023 11:57
@TerraVenil
Copy link
Contributor Author

Hi, @vishal-ph . Just let me know if we want to handle analytical_simulator in a special way.

@Q-lds Q-lds added the bug Something isn't working label Jun 13, 2023
@Q-lds
Copy link
Member

Q-lds commented Jun 13, 2023

@TerraVenil, very nice contribution! I just left two minor comments/suggestions and then we are good to merge :)

[edit] Make sure you write a message under #235, so that I can assign the issue to you :)

@Q-lds Q-lds merged commit 394f077 into entropicalabs:dev Jun 13, 2023
@Q-lds Q-lds linked an issue Jun 13, 2023 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add result statistics on measurement outcomes in QAOAResult object
3 participants