Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix dump methods #225

Merged
merged 11 commits into from
Apr 20, 2023
Merged

Bugfix dump methods #225

merged 11 commits into from
Apr 20, 2023

Conversation

Q-lds
Copy link
Member

@Q-lds Q-lds commented Apr 9, 2023

Description

Bug Fixes and Enhancements:

  • q.dump was not working for some backends. The issue was the wrong serialization of numpy values (measurement results and costs, both in the intermediate and in the optimized result)
  • Target and Cloud in the header are now automatically inferred
  • Some standard QAOA values are automatically added to the header's metadata
  • function naming
  • variable names
  • fix some issues related to flake8

Checklist

  • I have performed a self-review of my code.
  • I have commented my code and used numpy-style docstrings
  • I have made corresponding updates to the documentation.
  • My changes generate no new warnings
  • [x I have added/updated tests to make sure bugfix/feature works.
  • New and existing unit tests pass locally with my changes.

@Q-lds Q-lds changed the base branch from main to dev April 9, 2023 07:04
@Q-lds Q-lds requested review from vishal-ph and shahidee44 and removed request for vishal-ph April 9, 2023 07:10
@Q-lds Q-lds added bug Something isn't working enhancement New feature or request labels Apr 9, 2023
@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Merging #225 (58a5d08) into dev (945ae3f) will decrease coverage by 0.24%.
The diff coverage is 96.53%.

@@            Coverage Diff             @@
##              dev     #225      +/-   ##
==========================================
- Coverage   97.72%   97.48%   -0.24%     
==========================================
  Files          37       37              
  Lines        6771     6932     +161     
==========================================
+ Hits         6617     6758     +141     
- Misses        154      174      +20     
Impacted Files Coverage Δ
tests/test_backends.py 50.74% <ø> (-0.73%) ⬇️
tests/test_circuit_routing.py 71.70% <75.00%> (-0.28%) ⬇️
tests/test_qpu_qiskit.py 88.88% <76.00%> (-6.20%) ⬇️
tests/test_problems.py 99.15% <99.15%> (-0.01%) ⬇️
tests/test_benchmark.py 99.61% <100.00%> (+0.01%) ⬆️
tests/test_converters.py 100.00% <100.00%> (ø)
tests/test_notebooks.py 94.11% <100.00%> (+0.11%) ⬆️
tests/test_operators.py 100.00% <100.00%> (ø)
tests/test_qpu_braket.py 95.27% <100.00%> (ø)
tests/test_qpu_devices.py 98.63% <100.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

tests/test_workflows.py Outdated Show resolved Hide resolved
@vishal-ph vishal-ph self-requested a review April 17, 2023 06:32
tests/test_backends.py Outdated Show resolved Hide resolved
@vishal-ph vishal-ph merged commit 86771b2 into dev Apr 20, 2023
@vishal-ph vishal-ph deleted the bugfix_dump_methods branch April 20, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants