Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Deprecation Warning #217

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Fixing Deprecation Warning #217

merged 3 commits into from
Mar 28, 2023

Conversation

shahidee44
Copy link
Collaborator

@shahidee44 shahidee44 commented Mar 27, 2023

Description

  • Added qiskit_ibm_provider to setup.py
  • Fixed Qiskit's deprecation warning
  • Changed IBMQ import to IBMProvider.
  • Updated DeviceQiskit to accommodate assembling of instance string for IBMProvider
  • Updated Exceptions in Qiskit QPU Backend to import from qiskit_ibm_provider
  • Updated unittest test_changing_provider in test_qpu_devices.py
  • Updated test_dev.yml for new save_account through IBMProvider

Checklist

  • I have performed a self-review of my code.
  • I have commented my code and used numpy-style docstrings
  • I have made corresponding updates to the documentation.
  • My changes generate no new warnings
  • I have added/updated tests to make sure bugfix/feature works.
  • New and existing unit tests pass locally with my changes.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Name the new unit-tests that you have added along with this change.

@vishal-ph vishal-ph marked this pull request as ready for review March 27, 2023 14:59
@Q-lds Q-lds added bug Something isn't working enhancement New feature or request labels Mar 28, 2023
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #217 (3278e64) into dev (c9ff7dd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #217   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files          37       37           
  Lines        6769     6771    +2     
=======================================
+ Hits         6615     6617    +2     
  Misses        154      154           
Impacted Files Coverage Δ
setup.py 100.00% <ø> (ø)
tests/test_qpu_devices.py 98.63% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vishal-ph vishal-ph merged commit d353fe4 into dev Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants