Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed file name dump method workflows #200

Merged
merged 2 commits into from
Mar 14, 2023
Merged

fixed file name dump method workflows #200

merged 2 commits into from
Mar 14, 2023

Conversation

raulconchello
Copy link
Contributor

The dump method was giving the following name:
{experiment_id}--{atomic_id}

the correct one is:
{project_id}--{experiment_id}--{atomic_id}

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #200 (54d0c70) into dev (9d39cb1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #200      +/-   ##
==========================================
+ Coverage   88.79%   88.81%   +0.02%     
==========================================
  Files          32       32              
  Lines        5799     5812      +13     
==========================================
+ Hits         5149     5162      +13     
  Misses        650      650              
Impacted Files Coverage Δ
tests/test_workflows.py 99.50% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@raulconchello raulconchello marked this pull request as ready for review March 13, 2023 02:20
@Q-lds
Copy link
Member

Q-lds commented Mar 13, 2023

@raulconchello what's the default value for the project id?

Project_id has to be a valid uuid4, it is provided by the user, and it now becomes necessary. That is, if no project id is specified what happens when one tires to save the result?

@Q-lds Q-lds self-assigned this Mar 13, 2023
@Q-lds Q-lds merged commit ad5e943 into dev Mar 14, 2023
@Q-lds Q-lds deleted the fix_file_name_dump branch March 14, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants