Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev bipartite graphs #104

Merged
merged 11 commits into from
Oct 27, 2022
Merged

Dev bipartite graphs #104

merged 11 commits into from
Oct 27, 2022

Conversation

vishal-ph
Copy link
Collaborator

@vishal-ph vishal-ph commented Oct 20, 2022

Description

  • Add a tutorial notebook solving MVC with OpenQAOA

Type of change

Please delete options that are not relevant.

  • New tutorial notebook

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #104 (55b228f) into dev (431b683) will decrease coverage by 5.45%.
The diff coverage is 67.44%.

@@            Coverage Diff             @@
##              dev     #104      +/-   ##
==========================================
- Coverage   92.84%   87.38%   -5.46%     
==========================================
  Files          60       67       +7     
  Lines        7629     8904    +1275     
==========================================
+ Hits         7083     7781     +698     
- Misses        546     1123     +577     
Impacted Files Coverage Δ
openqaoa/backends/qpus/qaoa_qiskit_qpu.py 21.68% <0.00%> (-0.27%) ⬇️
openqaoa/backends/simulators/qaoa_qiskit_sim.py 100.00% <ø> (ø)
openqaoa/qaoa_parameters/gatemap.py 88.02% <0.00%> (ø)
openqaoa/qaoa_parameters/operators.py 100.00% <ø> (ø)
openqaoa/workflows/optimizer.py 83.15% <ø> (-0.18%) ⬇️
setup.py 100.00% <ø> (ø)
tests/test_results.py 100.00% <ø> (ø)
tests/test_qpu_braket.py 10.82% <10.82%> (ø)
openqaoa/backends/qpus/qaoa_braket_qpu.py 22.09% <22.09%> (ø)
openqaoa/devices.py 48.57% <23.33%> (-46.50%) ⬇️
... and 48 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Q-lds
Copy link
Member

Q-lds commented Oct 20, 2022

A few ideas to improve this PR:

  • The notebook contains a lot of functions: shouldn't these functions be part of a regular .py file? Maybe some utilities file in the problem folder?
  • We need tests for the new functions
  • The JSON inputs should be moved somewhere else: perhaps in a new folder, examples/problem_input?
  • The notebook itself should be moved to the example section. It could also be expanded a bit more

@vishal-ph vishal-ph requested a review from Q-lds October 27, 2022 04:39
@Q-lds Q-lds merged commit 9ca51d5 into dev Oct 27, 2022
@Q-lds Q-lds deleted the dev_bipartite_graphs branch October 27, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants