-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of pennylane optimizers #101
Implementation of pennylane optimizers #101
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #101 +/- ##
==========================================
- Coverage 87.01% 80.07% -6.95%
==========================================
Files 67 93 +26
Lines 9006 10969 +1963
==========================================
+ Hits 7837 8783 +946
- Misses 1169 2186 +1017
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@raulconchello you need to import pytest in the notebook_test file, see openqaoa/tests/test_notebooks.py Line 7 in 1887f41
|
Damn! I almost forgot! We also need to update the documentation:
|
Another thing that came to mind: we need to make sure that the optimisers work well also from the point of view of the workflows. The first step is to add them here: https://github.com/raulconchello/openqaoa/blob/115b5766c38767cbe5d8fdf18f5f6f0225bf8012/openqaoa/workflows/parameters/qaoa_parameters.py#L29 (Again, the fact that we are not doing this but that the tests is using the workflows suggests that the tests have not been running correctly) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple comments pending response
Implementation of the classical optimizers of the PennyLane library
The following optimizers have been added:
These have been implemented without changing the existing structure.
In the
setup.py
, the dependency with PennyLane has been introduced.Also, a test for these methods is added.