Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on nitpicky mode for documentation builds #429

Merged
merged 2 commits into from
Jul 17, 2021
Merged

Turn on nitpicky mode for documentation builds #429

merged 2 commits into from
Jul 17, 2021

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Jul 16, 2021 •
edited
Loading

Penultimate step towards solving #354: turn on nitpicky mode.

I'm expecting the CI to fail for this PR. It should pass after we've fixed the last of the broken references (in a separate PR: #430).

@mdickinson
Copy link
Member Author

CI failed as expected:

Warning, treated as error:
/home/runner/work/traits-futures/traits-futures/docs/source/guide/testing.rst:65:py:class reference target not found: pyface.ui.qt4.util.gui_test_assistant.GuiTestAssistant
Error: Process completed with exit code 2.

@mdickinson mdickinson mentioned this pull request Jul 16, 2021
Merged
rahulporuri
rahulporuri approved these changes Jul 17, 2021
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes themselves LGTM and the CI should be happy once the other PRs are merged and main is merged into this branch/PR.

@mdickinson mdickinson merged commit 6bd09ef into main Jul 17, 2021
@mdickinson mdickinson deleted the doc/turn-on-nitpicky-mode branch July 17, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdickinson @rahulporuri