Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and clean up multiaxis.py example #513

Merged
merged 6 commits into from
Feb 18, 2020
Merged

Fix and clean up multiaxis.py example #513

merged 6 commits into from
Feb 18, 2020

Conversation

jonathanrocher
Copy link
Collaborator

@jonathanrocher jonathanrocher commented Feb 5, 2020 •
edited
Loading

  • Aligned j0, j2 and j3's value_mapper so curves are correctly placed. To some extent, that changes a bit the purpose of the example to be more like the kind of thing that's scientifically useful (as opposed to disconnecting 4 plot's y mappers, but only displaying 2 axis).
  • Added axis titles to clarify where to read y-values.
  • Added a zoom tool because it is tricky to do and universally needed.
  • pep8 fixes.

@jonathanrocher jonathanrocher changed the title Example: improve multiaxis.py Fix and clean up multiaxis.py example Feb 6, 2020
jvkersch
jvkersch approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@jvkersch jvkersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonathanrocher
Copy link
Collaborator Author

Thanks for the review! Merging...

@jonathanrocher jonathanrocher merged commit 54727c9 into master Feb 18, 2020
@jonathanrocher jonathanrocher deleted the doc/add_multiaxis_axis_titles branch February 18, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvkersch jvkersch jvkersch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanrocher @jvkersch