Fix acceptance tests container launching issue #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A change[1] was backported to golang 1.19 that introduces additional checks on the `Host` HTTP header. The docker client connecting via Unix domain socket to the docker daemon does not specify the `Host` header and that triggers the error `http: invalid Host header`. The fix[2] was introduced in an unreleased version[3] of docker client which we use via commit id here to resolve the issue. [1] golang/go#61075 [2] moby/moby#45935 [3] moby/moby#45971
|
Included #848 to reduce the CI churn |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #852 +/- ##
=======================================
Coverage 77.60% 77.60%
=======================================
Files 54 54
Lines 4688 4688
=======================================
Hits 3638 3638
Misses 1050 1050
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Merging to unblock other PRs |
zregvart
added a commit
to zregvart/ec-cli
that referenced
this pull request
Aug 3, 2023
zregvart
added a commit
to zregvart/ec-cli
that referenced
this pull request
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change[1] was backported to golang 1.19 that introduces additional checks on the
HostHTTP header. The docker client connecting via Unix domain socket to the docker daemon does not specify theHostheader and that triggers the errorhttp: invalid Host header.The fix[2] was introduced in an unreleased version[3] of docker client which we use via commit id here to resolve the issue.
[1] golang/go#61075
[2] moby/moby#45935
[3] moby/moby#45971