Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main #162

Merged
merged 23 commits into from
Oct 23, 2024
Merged

Main #162

merged 23 commits into from
Oct 23, 2024

Conversation

entelecheia
Copy link
Owner

@entelecheia entelecheia commented Oct 23, 2024

Automatically generated by python-semantic-release

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Summary by Sourcery

Revise the release workflow to enhance efficiency and reliability by simplifying the pipeline and adjusting job settings. Upgrade python-semantic-release to version 9.0.0 and fix several issues related to semantic release configuration and version management. Update the chezmoi data file version and improve the build process.

New Features:

  • Upgrade python-semantic-release to version 9.0.0.

Bug Fixes:

  • Fix semantic release configuration by cleaning up commented settings.
  • Update version source for chezmoi data file.
  • Enable commit in release workflow.
  • Improve version update command in build process.

Enhancements:

  • Simplify release pipeline configuration by removing unused steps and adjusting job settings.

CI:

  • Modify the release workflow to use a concurrency group and adjust permissions for id-token and contents.

entelecheia and others added 23 commits October 19, 2024 19:58
Automatically generated by python-semantic-release
Automatically generated by python-semantic-release
Automatically generated by python-semantic-release
Automatically generated by python-semantic-release
Automatically generated by python-semantic-release
Automatically generated by python-semantic-release
Copy link

codesandbox bot commented Oct 23, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor β€’ VS Code β€’ Insiders

Open Preview

@zube zube bot added the [zube]: Inbox label Oct 23, 2024
Copy link

sourcery-ai bot commented Oct 23, 2024

Reviewer's Guide by Sourcery

This pull request updates the release workflow, modifies version information, and removes some files. The main changes include updating the semantic release process, adjusting environment configurations, and updating package information.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update release workflow to use python-semantic-release v9.12.0
  • Replace custom release job with Semantic Version Release action
  • Remove matrix strategy for OS and Python version
  • Update permissions for the release job
  • Remove poetry installation and dependency setup steps
.github/workflows/release.yaml
Update version information in multiple files
  • Add new version entries to CHANGELOG.md
  • Update DOTFILES_VERSION in .chezmoidata.yaml
CHANGELOG.md
chezmoi/.chezmoidata.yaml
Modify environment configuration
  • Change VIRTUAL_ENV path to use a local .venv directory instead of WORKON_HOME
.envrc
Remove unnecessary files
  • Delete .tasks.toml
  • Delete .readthedocs.yaml
  • Delete .todo.md
.tasks.toml
.readthedocs.yaml
.todo.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@entelecheia entelecheia merged commit a90d3f9 into release Oct 23, 2024
1 check was pending
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Oct 23, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @entelecheia - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟒 General issues: all looks good
  • 🟒 Security: all looks good
  • 🟒 Testing: all looks good
  • 🟒 Complexity: all looks good
  • 🟒 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click πŸ‘ or πŸ‘Ž on each comment and I'll use the feedback to improve your reviews.

@zube zube bot removed the [zube]: Done label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant