This repository has been archived by the owner on May 14, 2024. It is now read-only.
Fix opacity 0% backdrop blocking ui for firefox #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
705c51c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9107afbb.bada-frame.pages.dev |
| Branch Preview URL: | https://update-opacity-0-fix-for-fir.bada-frame.pages.dev |
abhinavkgrd
force-pushed
the
update-opacity-0-fix-for-firefox
branch
from
bfaf03e
to
705c51c
Compare
abhinavkgrd
changed the title
abhinavkgrd
changed the title
ua741
approved these changes
May 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Firefox doesn't support
:haspseudo selector so this fix doesn't work #1117For now, delaying the end animation to 300ms (default 178ms) seems to have done the trick and Jishnu and I both are now not able to reproduce the issue.
Test Plan
tested by jishnu