Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auth] Bugfix/auth icons with period #3559

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

Choromanski
Copy link
Contributor

@Choromanski Choromanski commented Oct 3, 2024

Description

Previously it would check if the substring that precedes the first . or ( of the lowercase spaceless provider title was a valid icon.

Now:

  1. Checks if lowercase spaceless provider title is valid icon
  2. If the title contains a ( it checks if the preceding part of the title is a valid icon
  3. If the title contains a . it checks if the preceding part of the title is a valid icon
Provider Title Previous Check Now Checks
Login.gov login login.gov
GOV.UK (Brian) gov gov.uk(brian)❌ then gov.uk
PayPal.com (Visa) paypal paypal.com(visa) ❌ then paypal.com ❌ then paypal
Amazon.com amazon amazon.com ❌ then amazon

This PR resolves issue #3473

@ua741 ua741 enabled auto-merge (squash) October 17, 2024 06:43
@ua741 ua741 merged commit 6f5c1b8 into ente-io:main Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants