Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitwarden import #348

Merged
merged 7 commits into from
Nov 14, 2023
Merged

Bitwarden import #348

merged 7 commits into from
Nov 14, 2023

Conversation

i-aiymen
Copy link
Contributor

@i-aiymen i-aiymen commented Nov 14, 2023

Description

Added: Import from bitwarden functionality
Closes #222

Type of Change

  • 🖼️ New icon
  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@i-aiymen
Copy link
Contributor Author

@vishnukvmd @ua741

Copy link
Member

@vishnukvmd vishnukvmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you confirm that the import is working for the sample data provided in the issue description @ #222?

lib/l10n/arb/app_en.arb Outdated Show resolved Hide resolved
lib/ui/settings/data/import/bitwarden_import.dart Outdated Show resolved Hide resolved
lib/ui/settings/data/import/bitwarden_import.dart Outdated Show resolved Hide resolved
lib/ui/settings/data/import/bitwarden_import.dart Outdated Show resolved Hide resolved
@i-aiymen
Copy link
Contributor Author

@vishnukvmd resolved the fixes

@vishnukvmd vishnukvmd merged commit 4ec71f6 into ente-io:main Nov 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support import from Bitwarden
2 participants