Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile faces v0 #1776

Merged
merged 542 commits into from
May 20, 2024
Merged

Mobile faces v0 #1776

merged 542 commits into from
May 20, 2024

Conversation

laurenspriem
Copy link
Member

No description provided.

laurenspriem and others added 30 commits April 24, 2024 16:01
@laurenspriem
[mob][photos] Use vectors everywhere in cluster suggestion
e829f7b
@laurenspriem
[mob][photos] Use SIMD in sorting suggestions too
3806ee3
@laurenspriem
[mob][photos] Remove redundant logging
05a4e9f
@laurenspriem
[mob][photos] Use cosineDistanceSIMD
462d1d4
@laurenspriem
[mob][photos] Correct suggestion logic again
e0fbb26
@laurenspriem
[mob][photos] Tiny change
72ff6e2
@laurenspriem
[mob][photos] Recompute suggestions on rejected suggestion
07458fb
@laurenspriem
[mob][photos] Fix bug
6f6f976
@laurenspriem
[mob][photos] Precompute face thumbnails for suggestions
3fbfa8c
@laurenspriem
[mob][photos] Increase the pool for face thumbnail generation
244d562
@ashilkn
[mob] Crop image instead of using scale and translate transforms on O…
b022ef6 
…G image in CroppedFaceImageView widget
@laurenspriem
[mob][photos] Better sorting of faces in file info
d0420ce
@laurenspriem
[mob][photos] Always check big clusters first for suggestions
1ae4482
@laurenspriem
[mob][photos] Lower both hard and soft blur thresholds
7e00a47
@laurenspriem
[mob][photos] Higher conservative clustering threshold
7b8816a
@laurenspriem
[mob][photos] Trailing commas
d429efa
@ashilkn
[mob] perf: Decode images from which face is to be cropped, in an iso…
2f7e0cd 
…late to avoid jank
@laurenspriem
[mob][photos] Functionality to remove selected images from suggestion
f0ebdb2
@laurenspriem
[mob][photos] More use of sqlite async
7370557
@laurenspriem
[mob][photos] Automatically reject overlapping suggestions
43cbfbf
@laurenspriem
[mob][photos] Forgot method
7fd5ffc
@laurenspriem
[mob][photos] Tiny change
52a7f27
@laurenspriem
[mob][photos] Show faces in file info regardless of blur value
f101468
@laurenspriem
[mob][photos] Increase conservative clustering threshold slightly
3828fa3
@ashilkn
[mob] Wrote util methods to generate face thumbnails from an image path
f173bc4 
Need to decide on which util method to use of the two after performance testing
@ashilkn
[mob] Two varients of CroppedFaceImageView for testing out which is m…
7617817 
…ore performant
@laurenspriem
[mob][photos] Moving more methods to sqlite async
b2a2078
@ashilkn
[mob] merge mobile_face to fix_face_thumbnail
a577611
@ashilkn
Revert "[mob] Two varients of CroppedFaceImageView for testing out wh…
3eebfdd 
…ich is more performant"

This reverts commit 7617817.
@ashilkn
Revert "[mob] perf: Decode images from which face is to be cropped, i…
b256bb2 
…n an isolate to avoid jank"

This reverts commit 2f7e0cd.
@laurenspriem laurenspriem requested a review from ua741 May 20, 2024 06:29
@ua741 ua741 enabled auto-merge May 20, 2024 12:16
ua741
ua741 approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@ua741 ua741 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📿

@ua741 ua741 merged commit b131472 into main May 20, 2024
2 checks passed
@ua741 ua741 deleted the mobile_face branch May 20, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ua741 ua741 ua741 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laurenspriem @ua741 @ashilkn @vishnukvmd