Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mob][photos][internal] Enable fav + add to album action for shared files #1484

Merged
merged 19 commits into from
Apr 20, 2024
Merged

[mob][photos][internal] Enable fav + add to album action for shared files #1484

merged 19 commits into from
Apr 20, 2024

Conversation

ua741
Copy link
Member

@ua741 ua741 commented Apr 19, 2024 •
edited
Loading

Description

Simulator.Screen.Recording.-.iPhone.15.-.2024-04-20.at.11.49.27.mp4

Tests

  • Hide Shared Item on Home Page If user has copied it.
  • Keep the fav state on the UI
  • Client side hash based dedupe works for copied items. Items are linked to existing item instead of uploading duplicate entries
  • Fav and add shared photos option is disabled for non-internal users

ua741 added 17 commits April 18, 2024 15:11
@ua741
[mob][photos] Minor refactor
b18e5cb
@ua741
[mob][photos] Rename method
420cec0
@ua741
[mob] Add assertion check
b8ad320
@ua741
[mob][photos] Enable fav incoming files
7631eb3
@ua741
[mob][photos] Lint fix
398e66a
@ua741
[mob][photos] Hide incoming file from home screen is saved
7f879aa
@ua741
[mob][photos]Fix: Show fav icon on shared photos
3788fdd
@ua741
[mob][photos] Fix: Remove fav action on shared photos
136f53b
@ua741
Merge remote-tracking branch 'origin/main' into mobile_save_a_copy
564ca77
@ua741
[mob][photos] Use loading indicator instead of blocking progress
08040d9
@ua741
[mob][photos] Fix: Pass copy of EnteFile to avoid modification in ori…
f55fd36 
…ginal
@ua741
[mob][photos] Lint fix
02890a1
@ua741
[mob][photos] Dedupe using hash before copying
01822b7
@ua741
[mob][photos] Add additional check for fileType
fc5705d
@ua741
[mob][photos] Enable add to option for shared photos for internal users
9a34fdc
@ua741
[mob][photos] Fix ownerID for copied items
e2aae74
@ua741
[mob][photos] Lint
c165b9e
@ua741 ua741 changed the title [mob][photos][internal] Enable fav action on shared files [mob][photos][internal] Enable fav + add to album action for shared files Apr 20, 2024
@ua741 ua741 mentioned this pull request Apr 20, 2024
Merged
ua741 added a commit that referenced this pull request Apr 20, 2024
@ua741
[server] Support for copying files owned by others (#1496)
b7d002f 
## Description

## Tests
Tested as part of #1484
- Verified that the client was able to download and decrypt the metadata
- Verified that storage was going up.
@ua741 ua741 marked this pull request as ready for review April 20, 2024 10:00
@ua741 ua741 enabled auto-merge April 20, 2024 10:00
@ua741 ua741 merged commit 3e5648d into main Apr 20, 2024
2 checks passed
@ua741 ua741 deleted the mobile_save_a_copy branch April 20, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishnukvmd vishnukvmd vishnukvmd approved these changes

@ashilkn ashilkn Awaiting requested review from ashilkn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ua741 @vishnukvmd