Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

File Open Dialog #1700

Merged
merged 29 commits into from
Jul 23, 2021
Merged

File Open Dialog #1700

merged 29 commits into from
Jul 23, 2021

Conversation

farmaazon
Copy link
Collaborator

@farmaazon farmaazon commented Jul 12, 2021

Pull Request Description

This PR contains the ctrl/cmd + o dialog where user can pick a project to open, and in future the file browser will be displayed.

This PR contains the API for not-yet-implemented file browser component, and the API is already integrated with controllers, and the integration was tested on the old file browser, which, alas, has been reverted.

image

Important Notes

Checklist

Please include the following checklist in your PR:

  • The CHANGELOG.md was updated with the changes introduced in this PR.
  • The documentation has been updated if necessary.
  • All code conforms to the Rust style guide.
  • All code has automatic tests where possible.
  • All code has been profiled where possible.
  • All code has been manually tested in the IDE.
  • All code has been manually tested in the "debug/interface" scene.
  • All code has been manually tested by the PR owner against our test scenarios.
  • All code has been manually tested by at least one reviewer against our test scenarios.

@farmaazon farmaazon added Difficulty: Core Contributor Should only be attempted by a core contributor Priority: High Should be scheduled as soon as possible Type: Enhancement An enhancement to the current state of Enso IDE Category: Controllers The Application layer not bound to visual part Category: GUI The Graphical User Interface labels Jul 12, 2021
@farmaazon farmaazon self-assigned this Jul 12, 2021
@farmaazon farmaazon requested a review from wdanilo as a code owner July 12, 2021 11:30
@s9ferech
Copy link
Contributor

When I use the scroll wheel on the file manager then it also scrolls the graph in the background.

Copy link
Contributor

@s9ferech s9ferech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I open the dialogue immediately after starting the IDE then the "Press tab key to search for components" label is in front of it:
press tab

@s9ferech
Copy link
Contributor

When a folder cannot be opened, the browser displays a message that was likely not written for users:
error message

@s9ferech
Copy link
Contributor

s9ferech commented Jul 12, 2021

I would suggest to put folders at the top, by default, since that is how I know it from most systems.

I would also propose to use natural sort order among files and folders in the future.

@s9ferech
Copy link
Contributor

I would expect that the dialogue closes when I click on the background.

@farmaazon farmaazon force-pushed the wip/ao/file-open-dialog branch from 4c40f96 to 263cba7 Compare July 12, 2021 16:01
@farmaazon farmaazon changed the base branch from wip/ao/file-open-dialog-start to develop July 12, 2021 16:01
@s9ferech
Copy link
Contributor

Since the browser allows to paste files, I think it we should soon add the feature to delete files. I assume this will not be difficult to implement.

@s9ferech
Copy link
Contributor

We should probably also soon add an icon for the Standard.Base library. At least, it should use the "Project" icon rather than the root icon, in my opinion.

@s9ferech
Copy link
Contributor

s9ferech commented Jul 12, 2021

Dropping files onto the file browser inserts them into the graph behind the browser, which is unexpected for me.

@farmaazon farmaazon changed the title File Open Dialog File Open Dialog and namespaces integration Jul 12, 2021
@s9ferech
Copy link
Contributor

This is not a surprise, but the file browser does not adopt to narrow windows. Neither does it make good use of large windows.

@farmaazon
Copy link
Collaborator Author

Additionally, after navigating in graph, the file browser events are misplaced. I'll tried to apply a workaround, but it does not work.

@s9ferech
Copy link
Contributor

The ordering of content roots changes between restarts. A consistent ordering would make it more predictable for the user. This might also affect the ordering of files and folders on some systems, but they were always sorted alphabetically for me.

@farmaazon farmaazon force-pushed the wip/ao/file-open-dialog branch from 263cba7 to 2182393 Compare July 19, 2021 08:35
@farmaazon farmaazon changed the title File Open Dialog and namespaces integration File Open Dialog Jul 23, 2021
@farmaazon farmaazon merged commit 6f8b9a9 into develop Jul 23, 2021
@farmaazon farmaazon deleted the wip/ao/file-open-dialog branch July 23, 2021 16:49
mwu-tow pushed a commit to enso-org/enso that referenced this pull request Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Controllers The Application layer not bound to visual part Category: GUI The Graphical User Interface Difficulty: Core Contributor Should only be attempted by a core contributor Priority: High Should be scheduled as soon as possible Type: Enhancement An enhancement to the current state of Enso IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants