This repository has been archived by the owner on Dec 28, 2021. It is now read-only.
Update API to support the new content roots #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
added
Difficulty: Hard
mwu-tow
approved these changes
Jun 24, 2021
src/rust/ide/lib/enso-protocol/src/language_server/connection.rs
Outdated
Show resolved
Hide resolved
src/rust/ide/lib/enso-protocol/src/language_server/connection.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Michał Wawrzyniec Urbańczyk <[email protected]>
wdanilo
approved these changes
Jun 25, 2021
farmaazon
added a commit
that referenced
this pull request
Jun 29, 2021
This reverts commit 5e472ce.
farmaazon
added a commit
that referenced
this pull request
Jul 2, 2021
farmaazon
added a commit
that referenced
this pull request
Jul 5, 2021
farmaazon
added a commit
that referenced
this pull request
Jul 5, 2021
farmaazon
added a commit
that referenced
this pull request
Jul 9, 2021
mwu-tow
pushed a commit
to enso-org/enso
that referenced
this pull request
Oct 30, 2021
mwu-tow
pushed a commit
to enso-org/enso
that referenced
this pull request
Oct 30, 2021
This reverts commit e266f03. Original commit: enso-org/ide@e2476ee
mwu-tow
pushed a commit
to enso-org/enso
that referenced
this pull request
Oct 30, 2021
…/ide#1640)"" This reverts commit dd94908. Original commit: enso-org/ide@c40d8e5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci no changelog needed]
Pull Request Description
This PR updates the language server protocol client to match the current state described in specification: The new ContentRoot structure.
Additionally, when project fails to open and we know that the engine's version is unsupported, we will inform the user about the fact (and give a hint how to fix that).
Important Notes
Currently the default engine version is nightly (with the new content roots). Once new Engine will be released, we should cuse the officially released version.
Checklist
Please include the following checklist in your PR:
TheCHANGELOG.mdwas updated with the changes introduced in this PR.All code has been manually tested by the PR owner against our test scenarios.All code has been manually tested by at least one reviewer against our test scenarios.