This repository has been archived by the owner on Dec 28, 2021. It is now read-only.
Correctly interpret string arguments as booleans in electron arguments. #1539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Previously arguments were passed to the main function as strings when using the electron app, or as booleans when using the development environment. Since false is a truthy value that was not further checked, this lead to wrong settings.
This PR adds a conversion of true and false to their boolean values, and adds an assertion that ensures that arguments are actually booleans.
Important Notes
Converts content/index.js to typescript.
Checklist
Please include the following checklist in your PR:
CHANGELOG.md
was updated with the changes introduced in this PR.All code has automatic tests where possible.All code has been profiled where possible.All code has been manually tested in the "debug/interface" scene.