Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

Correctly interpret string arguments as booleans in electron arguments. #1539

Merged
merged 10 commits into from
May 10, 2021

Conversation

MichaelMauderer
Copy link
Contributor

@MichaelMauderer MichaelMauderer commented Apr 30, 2021

Pull Request Description

Previously arguments were passed to the main function as strings when using the electron app, or as booleans when using the development environment. Since false is a truthy value that was not further checked, this lead to wrong settings.
This PR adds a conversion of true and false to their boolean values, and adds an assertion that ensures that arguments are actually booleans.

Important Notes

Converts content/index.js to typescript.

Checklist

Please include the following checklist in your PR:

  • The CHANGELOG.md was updated with the changes introduced in this PR.
  • The documentation has been updated if necessary.
  • All code conforms to the Rust style guide.
  • All code has automatic tests where possible.
  • All code has been profiled where possible.
  • All code has been manually tested in the IDE.
  • All code has been manually tested in the "debug/interface" scene.
  • All code has been manually tested by the PR owner against our test scenarios.
  • All code has been manually tested by at least one reviewer against our test scenarios.

@MichaelMauderer MichaelMauderer marked this pull request as ready for review April 30, 2021 19:13
@MichaelMauderer MichaelMauderer self-assigned this May 4, 2021
Copy link
Member

@wdanilo wdanilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot has changed here, especialy after moving to TypeScript. Im ok with all the changes, but I've got a question and request:

  1. I understand that it is formatted with prettier?
  2. Please triple check that everything works and there are not regressions with mixpanel etc.

@farmaazon farmaazon merged commit f0e712e into develop May 10, 2021
@farmaazon farmaazon deleted the wip/mm/fix-arguments-with-typescript branch May 10, 2021 17:23
mwu-tow pushed a commit to enso-org/enso that referenced this pull request Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants