This repository has been archived by the owner on Dec 28, 2021. It is now read-only.
Implement number and range pickers. #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelMauderer
added
Category: BaseGL
farmaazon
suggested changes
Apr 27, 2021
Co-authored-by: Adam Obuchowicz <[email protected]>
…the example prelude.
Co-authored-by: Adam Obuchowicz <[email protected]>
# Conflicts: # CHANGELOG.md
farmaazon
approved these changes
May 6, 2021
wdanilo
reviewed
May 10, 2021
There was a problem hiding this comment.
- This looks absolutely stunning!
- I'm surprised of how much code is there!
- I'm not sure the proposed generalization is the right one (I explained in the comment) - Ill think about it.
- After watching the video 100 times (because I love it), I started missing one thing - a visual indicator on double range slider (maybe we should put it on other as well) - tell ing me "if you press, only right side will move) - something like highlight of the right edge, or the whole slider when moving mouse around. Would it be hard to add such an indicator ?
| @@ -0,0 +1,134 @@ | |||
| use crate::prelude::*; | |||
There was a problem hiding this comment.
no docs. Please check config why error was not emitted here.
There was a problem hiding this comment.
There are no errors here (and in the other places noted) because none of this is public. All of this are utility modules that are not exposed as part of the selector module. So, they are public only within the selector module, but not outside it, and thus they are counted as not public.
wdanilo
approved these changes
May 18, 2021
# Conflicts: # src/rust/Cargo.lock
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Implements UI components for selecting number and a range of numbers according to #1199.
Peek.2021-04-26.09-45.mp4
Important Notes
?entry=slider. Shows a number of different possible configurations.Componentstruct as a general building block for Frp/Model-based UI components.Checklist
Please include the following checklist in your PR:
CHANGELOG.mdwas updated with the changes introduced in this PR.All code has automatic tests where possible.All code has been manually tested in the IDE.