Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

SQL Tooltip Above Nodes #1414

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

SQL Tooltip Above Nodes #1414

wants to merge 5 commits into from

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Mar 31, 2021 •
edited
Loading

Pull Request Description

Ensures that the tooltip in SQL visualization is displayed above other nodes by adding it directly to the front layer.

It uses onHide to remove the tooltip when the visualization is destroyed.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The CHANGELOG.md was updated with the changes introduced in this PR.
  • The documentation has been updated if necessary.
  • All code conforms to the Rust style guide.
  • All code has automatic tests where possible.
  • All code has been profiled where possible.
  • All code has been manually tested in the IDE.
  • All code has been manually tested in the "debug/interface" scene.
  • All code has been manually tested by the PR owner against our test scenarios.
  • All code has been manually tested by at least one reviewer against our test scenarios.

@radeusgd radeusgd requested a review from wdanilo as a code owner March 31, 2021 18:41
@radeusgd radeusgd force-pushed the wip/rw/sql-tooltip-above branch from 6aef359 to aa0fdba Compare March 31, 2021 18:43
@radeusgd radeusgd added Category: GUI The Graphical User Interface Category: Visualizations Visualizations embedded in Enso IDE Difficulty: Hard Significant prior knowledge requried Priority: High Should be scheduled as soon as possible Type: Enhancement An enhancement to the current state of Enso IDE labels Mar 31, 2021
@wdanilo
Copy link
Member

wdanilo commented Mar 31, 2021

We are waiting with this PR now to check if the onHide did not introduce a regression.

@wdanilo
Copy link
Member

wdanilo commented Jun 2, 2021

Hi, what is the status of this ?

@radeusgd
Copy link
Member Author

radeusgd commented Jun 2, 2021

The API it relies on has been reverted due to a regression. It is blocked by #1356

@MichaelMauderer MichaelMauderer marked this pull request as draft September 16, 2021 16:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wdanilo wdanilo Awaiting requested review from wdanilo wdanilo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@radeusgd radeusgd

Labels
Category: GUI The Graphical User Interface Category: Visualizations Visualizations embedded in Enso IDE Difficulty: Hard Significant prior knowledge requried Priority: High Should be scheduled as soon as possible Type: Enhancement An enhancement to the current state of Enso IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radeusgd @wdanilo @s9ferech