Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

Fix output port type when there are grey ports. #1409

Merged
merged 3 commits into from
Mar 30, 2021
Merged

Fix output port type when there are grey ports. #1409

merged 3 commits into from
Mar 30, 2021

Conversation

farmaazon
Copy link
Collaborator

Pull Request Description

The nodes with arguments placeholder have had no output types, this PR fixes that thing.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The CHANGELOG.md was updated with the changes introduced in this PR.
  • The documentation has been updated if necessary.
  • All code conforms to the Rust style guide.
  • All code has automatic tests where possible.
  • All code has been profiled where possible.
  • All code has been manually tested in the IDE.
  • All code has been manually tested in the "debug/interface" scene.
  • All code has been manually tested by the PR owner against our test scenarios.
  • All code has been manually tested by at least one reviewer against our test scenarios.

@farmaazon farmaazon requested a review from wdanilo as a code owner March 30, 2021 14:19
@farmaazon farmaazon self-assigned this Mar 30, 2021
@farmaazon farmaazon added Category: Controllers The Application layer not bound to visual part Category: GUI The Graphical User Interface Difficulty: Intermediate Some prior knowledge required Priority: Highest Should be completed ASAP Type: Bug A bug in Enso IDE labels Mar 30, 2021
@farmaazon farmaazon merged commit a189a74 into develop Mar 30, 2021
@farmaazon farmaazon deleted the wip/ao/fix-output-port-type branch March 30, 2021 15:49
mwu-tow pushed a commit to enso-org/enso that referenced this pull request Oct 30, 2021
@farmaazon
Fix output port type when there are grey ports [ci changelog not need…
edcbf24 
…ed] (enso-org/ide#1409)

Original commit: enso-org/ide@a189a74
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wdanilo wdanilo wdanilo approved these changes

Assignees

@farmaazon farmaazon

Labels
Category: Controllers The Application layer not bound to visual part Category: GUI The Graphical User Interface Difficulty: Intermediate Some prior knowledge required Priority: Highest Should be completed ASAP Type: Bug A bug in Enso IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farmaazon @wdanilo