This repository has been archived by the owner on Dec 28, 2021. It is now read-only.
Filter out Unresolved_Symbol when coloring ports #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
added
Good First Issue
wdanilo
approved these changes
Mar 30, 2021
CHANGELOG.md
Outdated
| @@ -210,6 +210,7 @@ users about errors and where they originate. | |||
| - Cursors in text editors behave correctly now (they are not affected by scene | |||
| pan and zoom). This was possible because of the new multi-camera management | |||
| system implemented in EnsoGL. | |||
| - [Fixed method names highlighted in pink][1408] | |||
There was a problem hiding this comment.
- Not a valid sentence.
- This should be better explained to the users, like "There was a bug introduced after one of the latest Engine updates, that sent ... types, which made .. pink. This is fixed now".
There was a problem hiding this comment.
But the "Unresolved" type was never shown to Users?
Comment on lines
62
to
63
| /// A type of unresolved methods. We filter them out, because they are not helpful from the UX | ||
| /// perspective. |
There was a problem hiding this comment.
This comment should be better - not "they are not helpful from the UX perspective". Rather - we don't want to treat them as types fo port coloring etc. Such comments should describe semantically why such a change is made.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
That fixes the "pink" methods.
Important Notes
Checklist
Please include the following checklist in your PR:
CHANGELOG.mdwas updated with the changes introduced in this PR.All code has been manually tested in the "debug/interface" scene.