Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

Show visualization available for node output type only. #1384

Merged
merged 10 commits into from
Mar 30, 2021

Conversation

farmaazon
Copy link
Collaborator

@farmaazon farmaazon commented Mar 25, 2021

Pull Request Description

  • The visualization chooser, contains only visualizations for node output port type
  • Cycling over visualizations cycles over available vis for given type

Important Notes

When the node has no output type, we display visualizations for Any.

Checklist

Please include the following checklist in your PR:

  • The CHANGELOG.md was updated with the changes introduced in this PR.
  • The documentation has been updated if necessary.
  • All code conforms to the Rust style guide.
  • All code has automatic tests where possible.
  • All code has been profiled where possible.
  • All code has been manually tested in the IDE.
  • All code has been manually tested in the "debug/interface" scene.
  • All code has been manually tested by the PR owner against our test scenarios.
  • All code has been manually tested by at least one reviewer against our test scenarios.

@farmaazon farmaazon added Difficulty: Intermediate Some prior knowledge required Priority: High Should be scheduled as soon as possible Type: Bug A bug in Enso IDE Category: GUI The Graphical User Interface Category: Visualizations Visualizations embedded in Enso IDE labels Mar 25, 2021
@farmaazon farmaazon self-assigned this Mar 25, 2021
@farmaazon farmaazon requested a review from wdanilo as a code owner March 25, 2021 14:05

// === Selecting Visualization ===
frp::extend! { network
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing

}


// === Fullscreen View ===
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing

@radeusgd
Copy link
Member

radeusgd commented Mar 26, 2021

Could you please also update the SQL Query visualization and check if it shows up correctly for DB Tables and Columns?

A scenario to test it (you can download the DB here: stores.zip)

file = Enso_Project.data / "stores.db"
db = Database.open_sqlite_file file
t1 = db.access_table "stores" # this should have an SQL Query visualization available
col = t1.at "name" # this also should have the above vis

Also just to remind, the Table visualization should work on Any since it handles arbitrary JSON representations.

@farmaazon farmaazon merged commit d4cc824 into develop Mar 30, 2021
@farmaazon farmaazon deleted the wip/ao/visualization-types branch March 30, 2021 12:25
mwu-tow pushed a commit to enso-org/enso that referenced this pull request Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: GUI The Graphical User Interface Category: Visualizations Visualizations embedded in Enso IDE Difficulty: Intermediate Some prior knowledge required Priority: High Should be scheduled as soon as possible Type: Bug A bug in Enso IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants