Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

Support Dataframes in Histogram and Scatter Plot Visualizations #1377

Merged
merged 7 commits into from
Mar 30, 2021
Merged

Support Dataframes in Histogram and Scatter Plot Visualizations #1377

merged 7 commits into from
Mar 30, 2021

Conversation

mwu-tow
Copy link
Contributor

@mwu-tow mwu-tow commented Mar 24, 2021 •
edited
Loading

Pull Request Description

Ref #1021

Important Notes

This PR depends on Engine enso-org/enso@5b57960 or newer.

Checklist

Please include the following checklist in your PR:

  • The CHANGELOG.md was updated with the changes introduced in this PR.
  • The documentation has been updated if necessary.
  • All code conforms to the Rust style guide.
  • All code has automatic tests where possible.
  • All code has been profiled where possible.
  • All code has been manually tested in the IDE.
  • All code has been manually tested in the "debug/interface" scene.
  • All code has been manually tested by the PR owner against our test scenarios.
  • All code has been manually tested by at least one reviewer against our test scenarios.

@mwu-tow mwu-tow added Difficulty: Core Contributor Should only be attempted by a core contributor Priority: Highest Should be completed ASAP Type: Enhancement An enhancement to the current state of Enso IDE Category: Visualizations Visualizations embedded in Enso IDE labels Mar 24, 2021
@mwu-tow mwu-tow self-assigned this Mar 24, 2021
@mwu-tow mwu-tow marked this pull request as ready for review March 25, 2021 16:59
farmaazon
farmaazon reviewed Mar 26, 2021
View reviewed changes
Copy link
Collaborator

@farmaazon farmaazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. I will test it once engine will be released with new standard library.

docs/product/visualizations.md Outdated
### Dataframes Support

Some of the predefined visualizations have some special support for `Table` from
Enso Dataframes library. By placing r
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an unfinished sentence.

@farmaazon farmaazon merged commit cd3a6e9 into develop Mar 30, 2021
@farmaazon farmaazon deleted the wip/mwu/scatterplot-dataframes-1021 branch March 30, 2021 07:36
mwu-tow added a commit to enso-org/enso that referenced this pull request Oct 30, 2021
@mwu-tow
Support Dataframes in Histogram and Scatter Plot Visualizations (enso…
7faf29e 
…-org/ide#1377)

Original commit: enso-org/ide@cd3a6e9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@farmaazon farmaazon farmaazon approved these changes

@wdanilo wdanilo Awaiting requested review from wdanilo wdanilo is a code owner

Assignees

@mwu-tow mwu-tow

Labels
Category: Visualizations Visualizations embedded in Enso IDE Difficulty: Core Contributor Should only be attempted by a core contributor Priority: Highest Should be completed ASAP Type: Enhancement An enhancement to the current state of Enso IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwu-tow @farmaazon