This repository has been archived by the owner on Dec 28, 2021. It is now read-only.
Enable build signing for macOS and Windows binaries. #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelMauderer
changed the title
MichaelMauderer
force-pushed
the
wip/mm/ide-1135-sign-windows-and-macos-binaries.-
branch
18 times, most recently
from
9e433da
to
ac53ec7
Compare
MichaelMauderer
force-pushed
the
wip/mm/ide-1135-sign-windows-and-macos-binaries.-
branch
4 times, most recently
from
92978f5
to
a156b47
Compare
MichaelMauderer
force-pushed
the
wip/mm/ide-1135-sign-windows-and-macos-binaries.-
branch
from
a156b47
to
4a4d1ae
Compare
…naries.- # Conflicts: # CHANGELOG.md
farmaazon
reviewed
May 25, 2021
farmaazon
approved these changes
May 25, 2021
wdanilo
suggested changes
Jun 2, 2021
…naries.- # Conflicts: # CHANGELOG.md
wdanilo
approved these changes
Jun 8, 2021
src/js/lib/client/tasks/notarize.js
Outdated
| } | ||
| // We need to manually re-sign our build artifacts before notarisation. | ||
| // See the script for more information. | ||
| console.log(" • Extra Signing.") |
There was a problem hiding this comment.
I mean in the console - it should be named in such a way that when we see it during building in console, we understand what is being done then.
farmaazon
pushed a commit
that referenced
this pull request
Jun 22, 2021
MichaelMauderer
deleted the
wip/mm/ide-1135-sign-windows-and-macos-binaries.-
branch
mwu-tow
pushed a commit
to enso-org/enso
that referenced
this pull request
Oct 30, 2021
mwu-tow
pushed a commit
to enso-org/enso
that referenced
this pull request
Oct 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci build]
Pull Request Description
Enables signing of our build artefacts for windows and macOS. For macOS, we also notarize the project.
Important Notes
[ci build]tag to be used in the PR body instead of the commit message.Checklist
Please include the following checklist in your PR:
CHANGELOG.mdwas updated with the changes introduced in this PR.All code has automatic tests where possible.All code has been profiled where possible.All code has been manually tested in the IDE.All code has been manually tested in the "debug/interface" scene.