Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

Add a theming API for visualizations #1358

Merged
merged 8 commits into from
Mar 24, 2021
Merged

Add a theming API for visualizations #1358

merged 8 commits into from
Mar 24, 2021

Conversation

s9ferech
Copy link
Contributor

@s9ferech s9ferech commented Mar 22, 2021

Pull Request Description

This solves issue #1337.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The CHANGELOG.md was updated with the changes introduced in this PR.
  • The documentation has been updated if necessary.
  • All code conforms to the Rust style guide.
  • All code has automatic tests where possible.
  • All code has been profiled where possible.
  • All code has been manually tested in the IDE.
  • All code has been manually tested in the "debug/interface" scene.
  • All code has been manually tested by the PR owner against our test scenarios.
  • All code has been manually tested by at least one reviewer against our test scenarios.

@s9ferech s9ferech added Priority: Highest Should be completed ASAP Type: Enhancement An enhancement to the current state of Enso IDE Category: Visualizations Visualizations embedded in Enso IDE labels Mar 22, 2021
@s9ferech s9ferech self-assigned this Mar 22, 2021
@s9ferech
Copy link
Contributor Author

I still have two questions:

  1. Should I update the documentation as part of this PR?
  2. Do we need to reload the visualisations on style changes?

@radeusgd
Copy link
Member

I still have two questions:

  1. Should I update the documentation as part of this PR?
  2. Do we need to reload the visualisations on style changes?

I'm not sure about (1) (I guess @wdanilo or @farmaazon will have a say here).

As for (2), I think it would make sense - if the colors for types can change with the theme, the visualization also needs to reflect this change to be consistent. Maybe we could allow some kind of callback telling the visualization to refresh its color scheme, but I think that would make it more complex for visualization creators, so IMO refreshing is the simplest solution here. What do you think?

@wdanilo
Copy link
Member

wdanilo commented Mar 23, 2021

  1. Of course. Docs are always part of the PR.
  2. Not now. We do not have proper theme reloading now, this will be a separate issue.

@s9ferech s9ferech marked this pull request as ready for review March 24, 2021 15:35
@s9ferech s9ferech merged commit 916d733 into develop Mar 24, 2021
@s9ferech s9ferech deleted the wip/fr/theming branch March 24, 2021 18:08
mwu-tow pushed a commit to enso-org/enso that referenced this pull request Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Visualizations Visualizations embedded in Enso IDE Priority: Highest Should be completed ASAP Type: Enhancement An enhancement to the current state of Enso IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants