Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

Implement tooltips that show the type of an output port on hover. #1312

Merged
merged 13 commits into from
Mar 17, 2021

Conversation

MichaelMauderer
Copy link
Contributor

@MichaelMauderer MichaelMauderer commented Mar 9, 2021

Pull Request Description

Implements #960.

Important Notes

  • There is an issue with text occlusion that needs to be addressed in the future. Right now there seems to be no good way to allow us to specify relative occlusion of text in the same way as shapes.
  • The tooltip cannot be part of the cursor because it would create cyclic dependencies: the cursor lives in enso-core, but the tooltip requires enso-text, which in turn depends on enso-core. Thus, it is implemented as a standalone entity in the graph editor. A more appropriate place might actually be next to the cursor in the Application, but the same issue is present there.

Checklist

Please include the following checklist in your PR:

  • The CHANGELOG.md was updated with the changes introduced in this PR.
  • The documentation has been updated if necessary.
  • All code conforms to the Rust style guide.
  • All code has automatic tests where possible.
  • All code has been profiled where possible.
  • All code has been manually tested in the IDE.
  • All code has been manually tested in the "debug/interface" scene.
  • All code has been manually tested by the PR owner against our test scenarios.
  • All code has been manually tested by at least one reviewer against our test scenarios.

@MichaelMauderer MichaelMauderer added Category: BaseGL The BaseGL library Priority: Medium Should be a complement for some iteration Type: Enhancement An enhancement to the current state of Enso IDE Category: GUI The Graphical User Interface labels Mar 9, 2021
@MichaelMauderer MichaelMauderer self-assigned this Mar 9, 2021
@MichaelMauderer MichaelMauderer force-pushed the wip/mm/ide-1062-type-labels branch 4 times, most recently from 42f3723 to 5b28468 Compare March 10, 2021 08:41
@farmaazon farmaazon requested a review from wdanilo March 10, 2021 09:16
@MichaelMauderer MichaelMauderer marked this pull request as ready for review March 10, 2021 09:16
@MichaelMauderer MichaelMauderer force-pushed the wip/mm/ide-1062-type-labels branch from 5b28468 to 77633f5 Compare March 10, 2021 12:32
@MichaelMauderer MichaelMauderer changed the title feat: Implement tooltips that show the type of an output port on hover. Implement tooltips that show the type of an output port on hover. Mar 10, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
src/rust/ensogl/lib/components/src/text_label.rs Outdated Show resolved Hide resolved
src/rust/ensogl/lib/components/src/text_label.rs Outdated Show resolved Hide resolved
src/rust/ensogl/lib/components/src/text_label.rs Outdated Show resolved Hide resolved
src/rust/ensogl/lib/components/src/text_label.rs Outdated Show resolved Hide resolved
src/rust/ide/view/graph-editor/src/component/tooltip.rs Outdated Show resolved Hide resolved
src/rust/ide/view/graph-editor/src/component/tooltip.rs Outdated Show resolved Hide resolved
src/rust/ide/view/graph-editor/src/component/tooltip.rs Outdated Show resolved Hide resolved
src/rust/ide/view/graph-editor/src/component/tooltip.rs Outdated Show resolved Hide resolved
src/rust/ide/view/graph-editor/src/component/tooltip.rs Outdated Show resolved Hide resolved
@MichaelMauderer MichaelMauderer force-pushed the wip/mm/ide-1062-type-labels branch from 9b22d87 to b199fed Compare March 12, 2021 15:19
@farmaazon farmaazon self-requested a review March 16, 2021 09:09
@MichaelMauderer MichaelMauderer merged commit f03a652 into develop Mar 17, 2021
@MichaelMauderer MichaelMauderer deleted the wip/mm/ide-1062-type-labels branch March 17, 2021 09:48
mwu-tow pushed a commit to enso-org/enso that referenced this pull request Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: BaseGL The BaseGL library Category: GUI The Graphical User Interface Priority: Medium Should be a complement for some iteration Type: Enhancement An enhancement to the current state of Enso IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants