Reduce ops when setting exisitng execution env #9967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting execution environment to the existing one should have no effect. Cancelling jobs and triggering a fresh execute job is expensive and unnecessary, especially on startup, when the result should be the same as before.
hubertp
added
the
CI: No changelog needed
4e6
approved these changes
May 16, 2024
vitvakatu
pushed a commit
that referenced
this pull request
May 17, 2024
Setting execution environment to the existing one should have no effect. Should (positively) affect startup in #9789. # Important Notes Cancelling jobs and triggering a fresh execute job is expensive and unnecessary, especially on startup, when the result should be the same as before.
Akirathan
reviewed
May 20, 2024
Comment on lines
+226
to
+227
| "-XX:ActiveProcessorCount=2", | ||
| "-Xmx8192m" |
There was a problem hiding this comment.
@hubertp Just randomly browsing through recent PRs, I have noticed this change. I assume it has something to do with performance. Could you share how the performance was affected? And give us more insight on why you have chosen these two cmdline options?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Setting execution environment to the existing one should have no effect.
Should (positively) affect startup in #9789.
Important Notes
Cancelling jobs and triggering a fresh execute job is expensive and unnecessary, especially on startup, when the result should be the same as before.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.