Reduce set of JDK modules required by Enso #9868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
hubertp
reviewed
May 7, 2024
| @@ -1,8 +1,8 @@ | |||
| open module org.enso.runtime { | |||
| requires java.base; | |||
| requires java.net.http; | |||
| // compiler shall not be need | |||
There was a problem hiding this comment.
This commit is the answer. engine/runtime needed a transitive dependency on java.compiler because of using String constant from interpreter-dsl project.
JaroslavTulach
added
the
CI: Clean build required
radeusgd
approved these changes
May 7, 2024
Akirathan
approved these changes
May 7, 2024
engine/runtime-integration-tests/src/test/java/org/enso/interpreter/test/BinaryOpFloatTest.java
Show resolved
Hide resolved
|
One (unrelated) test failure: https://github.com/enso-org/enso/actions/runs/8983445979/job/24673241959?pr=9868#step:7:2517 - merging.
|
This was referenced May 8, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 8, 2024
Fixes regression introduced by #9868 - language server still needs dependency on `java.desktop` and `java.se`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
On a quest to #9774 analyze content and size of
runnernative image, let's simplify module info to avoid modules likejava.desktop, if possible.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,