refr(enso-org/cloud-v2#1088): Make Project fields camelCase
#9653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies fields of `Project`-like structs to be `camelCase`. This brings more of the backend API into line with the existing style guide. Note that the changes in this commit are breaking if the IDE is run against a backend that hasn't been updated to account for the corresponding API changes.
indiv0
requested review from
PabloBuchu,
somebody1234 and
MrFlashAccount
as code owners
indiv0
added
the
CI: No changelog needed
somebody1234
approved these changes
Apr 8, 2024
somebody1234
reviewed
Apr 8, 2024
| }, | ||
| packageName: 'Project_root', | ||
| /* eslint-disable @typescript-eslint/naming-convention */ |
There was a problem hiding this comment.
prefer two separet eslint-disable-next-lines, that way we don't risk forgetting to re-enable it
| // eslint-disable-next-line @typescript-eslint/naming-convention, @typescript-eslint/no-unused-vars | ||
| const { opened_by, ...newProjectState2 } = newProjectState | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| const { openedBy, ...newProjectState2 } = newProjectState |
There was a problem hiding this comment.
i guess we should change this to use the object.omit, so that it no longer needs the lint disable:
... on that note it seems like there's a typo there. oh well... i might fix that at some point in the future
There was a problem hiding this comment.
Is the Ks the typo? What should it be?
There was a problem hiding this comment.
no the typo is in the docs, which say "runtie array" 😅
Ks is short for keys, maybe it should be renamed too though
MrFlashAccount
approved these changes
Apr 10, 2024
|
qa 🟢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies fields of
Project-like structs to becamelCase. This brings more of the backend API into line with the existing style guide.Note that the changes in this commit are breaking if the IDE is run against a backend that hasn't been updated to account for the corresponding API changes.
Pull Request Description
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.