Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undoing node removal #9561

Merged
merged 6 commits into from
Mar 29, 2024
Merged

Fix undoing node removal #9561

merged 6 commits into from
Mar 29, 2024

Conversation

farmaazon
Copy link
Contributor

@farmaazon farmaazon commented Mar 27, 2024

Pull Request Description

Fixes #9314

The node deletion does not remove AST node from the module, only unpin it from its parent; so undoing does not add this node, just modify it, and thus we weren't informed about metadata change.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • [ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@farmaazon farmaazon added CI: No changelog needed Do not require a changelog entry for this PR. --bug Type: bug -gui labels Mar 27, 2024
@farmaazon farmaazon self-assigned this Mar 27, 2024
@farmaazon farmaazon changed the title Fix undoing ndoe removal Fix undoing node removal Mar 27, 2024
@farmaazon farmaazon marked this pull request as ready for review March 27, 2024 14:55
@Frizi Frizi added the CI: Ready to merge This PR is eligible for automatic merge label Mar 29, 2024
@mergify mergify bot merged commit 2384fe8 into develop Mar 29, 2024
40 of 42 checks passed
@mergify mergify bot deleted the wip/farmaazon/fix-undoing-remove branch March 29, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undoing component deletion doesn't restore in the correct location
2 participants