-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some engine jobs that run with Oracle GraalVM #9322
Conversation
Oracle GraalVM seems to be downloaded and seems green. The same applies for scala tests on Oracle GraalVM. But where are GraalVM CE tests on Linux? Shouldn't we run both? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am impressed with how well you deal with the build script! 👍
I have a bunch of comments, mostly stylistic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am concerned by changes and renames to existing CI actions. I'd prefer to leave them as unchanged as possible. I am afraid the rename will affect other tools that rely on the existing name. Otherwise looks fine.
The #9322-generated changes did not include some later changes to the generator.
Closes #9266.
Pull Request Description
Adds
Oracle GraalVM
configuration for some backend jobs.Oracle GraalVM
jobs run only on Linux so far. The old jobs useGraalVM CE
.Important Notes
JAVA_VENDOR
environment variable. By default,GraalVM CE
is used.Current list of jobs in the
Engine CI
workflow (these jobs are visible on this PR, because they are scheduled to run on every PR):Benchmark Engine workflow (not visible on this PR, cannot schedule manually yet):
Benchmark Standard Libraries workflow (not visible on this PR, cannot schedule manually yet):
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR: