Allow resolving enso:// URIs in Data.read and other places
#9225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
requested review from
jdunkerley,
GregoryTravis and
AdRiley
as code owners
3 tasks
radeusgd
force-pushed
the
wip/radeusgd/9048-resolve-enso-uri
branch
from
08e17c8 to
6ed6f6e
Compare
5 tasks
radeusgd
force-pushed
the
wip/radeusgd/9123-first-data-links
branch
from
637a2cc to
81f9e40
Compare
radeusgd
requested review from
PabloBuchu,
indiv0,
somebody1234,
4e6,
JaroslavTulach,
hubertp,
Akirathan,
farmaazon and
wdanilo
as code owners
radeusgd
force-pushed
the
wip/radeusgd/9048-resolve-enso-uri
branch
from
6ed6f6e to
2063074
Compare
GregoryTravis
approved these changes
Feb 29, 2024
|
Sorry for pinging unrelated reviewers - GitHub did this automatically when changing PR's base branches. |
somebody1234
removed request for
indiv0,
PabloBuchu,
somebody1234,
4e6,
JaroslavTulach,
hubertp,
Akirathan,
farmaazon and
wdanilo
radeusgd
force-pushed
the
wip/radeusgd/9048-resolve-enso-uri
branch
from
2063074 to
0d58bb5
Compare
radeusgd
force-pushed
the
wip/radeusgd/9048-resolve-enso-uri
branch
2 times, most recently
from
6f4fc81 to
ed937ca
Compare
JaroslavTulach
approved these changes
Mar 1, 2024
std-bits/base/src/main/java/org/enso/base/enso_cloud/EnsoPathFileSystemSPI.java
Show resolved
Hide resolved
jdunkerley
approved these changes
Mar 1, 2024
Comment on lines
+81
to
+82
| is_path = name.starts_with "enso://" | ||
| case is_path of |
There was a problem hiding this comment.
don't see point of not putting into case statement.
There was a problem hiding this comment.
given how short the False branch is would probably have done if/then/else with the not condition but that is just stylistic.
There was a problem hiding this comment.
don't see point of not putting into case statement.
the point was to give this expression a name - for documentation purposes
…s) path resolution
radeusgd
force-pushed
the
wip/radeusgd/9048-resolve-enso-uri
branch
from
ed937ca to
f4944e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
enso://URIs inData.read#9048Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.