Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Keyboard shortcuts" settings page #9071

Merged
merged 25 commits into from
Feb 27, 2024
Merged

Conversation

somebody1234
Copy link
Contributor

@somebody1234 somebody1234 commented Feb 15, 2024

Pull Request Description

  • Close https://github.com/enso-org/cloud-v2/issues/896
    • Add new settings page for viewing and editing keyboard shortcuts
    • Refactor shortcut manager to resemble GUI2's shortcuts module
  • Minor refactor moving dashboard/layouts/dashboard to dashboard/layouts; and moving all moals to dashboard/modals

Important Notes

  • The modal for capturing keyboard shortcuts has not been tested on macOS.

Screenshots

Main settings page. Scrollbars are unstyled as the screenshot was taken on Firefox.
image

Buttons for removing, adding, and resetting the list of shortcuts for a specific action:
(These buttons appear on hover, similarly to the (+) on the "Labels" and "Shared with" columns)
image

Keyboard shortcut input modal (no shortcut entered):
image

Keyboard shortcut input modal (shortcut entered):
image

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@somebody1234 somebody1234 added CI: No changelog needed Do not require a changelog entry for this PR. x-new-feature Type: new feature request g-dashboard labels Feb 15, 2024
@PabloBuchu
Copy link
Contributor

PabloBuchu commented Feb 26, 2024

  1. When trying to assing cmd + <anything> I end up with double cmd (although it seems to work)
Screenshot 2024-02-26 at 16 24 57
  1. We should not allow to assing the same key / combination multiple times. Making input red and small info that this combination is taken should be enough

  2. What's the difference between move to trash and delete (+ all)

  3. On local Backspace is activating search bar

  4. Some combinations occurs multiple times within the same action

Screenshot 2024-02-26 at 16 41 43

@somebody1234
Copy link
Contributor Author

  1. will need to investigate
  2. will do
  3. this is a limitation of the current system - to display different text, they need to be different shortcuts... but on second thought - it's probably a better idea to simply override the text. will address soon.
  4. it's possible that this is because i don't handle Delete. will check.
  5. very weird, will investigate.

@somebody1234
Copy link
Contributor Author

somebody1234 commented Feb 26, 2024

the latest commit only fixes merge conflicts.
only issue 3 has been addressed so far - the rest may be addressed tomorrow.

@somebody1234
Copy link
Contributor Author

(another merge to fix conflicts. issues still not addressed.)

@somebody1234
Copy link
Contributor Author

somebody1234 commented Feb 26, 2024

  1. i think i found the problem but as usual cannot test.
  2. TODO. this is the biggest task so i left it for last.
  3. already addressed
  4. also fixed but needs testing.
  5. can't repro. will probably have to ask you to try some things tomorrow

@somebody1234
Copy link
Contributor Author

update: all issues other than number 5 should now be fixed.

@PabloBuchu PabloBuchu assigned PabloBuchu and unassigned indiv0 Feb 27, 2024
@PabloBuchu PabloBuchu added the CI: Ready to merge This PR is eligible for automatic merge label Feb 27, 2024
@mergify mergify bot merged commit e59b422 into develop Feb 27, 2024
27 of 29 checks passed
@mergify mergify bot deleted the wip/sb/keyboard-shortcuts-settings branch February 27, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard x-new-feature Type: new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants