-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Keyboard shortcuts" settings page #9071
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somebody1234
added
CI: No changelog needed
Do not require a changelog entry for this PR.
x-new-feature
Type: new feature request
g-dashboard
labels
Feb 15, 2024
|
the latest commit only fixes merge conflicts. |
(another merge to fix conflicts. issues still not addressed.) |
|
update: all issues other than number 5 should now be fixed. |
PabloBuchu
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI: No changelog needed
Do not require a changelog entry for this PR.
CI: Ready to merge
This PR is eligible for automatic merge
g-dashboard
x-new-feature
Type: new feature request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
dashboard/layouts/dashboard
todashboard/layouts
; and moving all moals todashboard/modals
Important Notes
Screenshots
Main settings page. Scrollbars are unstyled as the screenshot was taken on Firefox.
Buttons for removing, adding, and resetting the list of shortcuts for a specific action:
(These buttons appear on hover, similarly to the
(+)
on the "Labels" and "Shared with" columns)Keyboard shortcut input modal (no shortcut entered):
Keyboard shortcut input modal (shortcut entered):
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If GUI codebase was changed, the GUI was tested when built using./run ide build
.