Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vite-plugin-top-level-await plugin #9038

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

farmaazon
Copy link
Contributor

Pull Request Description

We've used the vite-plugin-top-level-await to support top level await. But most of them were removed anyway, because the ide-desktop/lib/client is bundled as CJS and use some of gui2 code. And the plugin is causing problems, also in our CI

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • [ ] The documentation has been updated, if necessary.
  • [ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • [ ] Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@farmaazon farmaazon added CI: No changelog needed Do not require a changelog entry for this PR. -ci --bug Type: bug -gui labels Feb 13, 2024
@farmaazon farmaazon self-assigned this Feb 13, 2024
@farmaazon farmaazon added the CI: Ready to merge This PR is eligible for automatic merge label Feb 13, 2024
@mergify mergify bot merged commit ee38136 into develop Feb 14, 2024
26 of 28 checks passed
@mergify mergify bot deleted the wip/farmaazon/remove-not-working-plugin branch February 14, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -ci -gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants