Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print stacktraces of IOException #9024

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Feb 12, 2024

Pull Request Description

Fixes #8896 by logging IOException only with WARNING and not SEVERE. As such the stacktrace of the exception isn't included in the console and failures to store cache are reported as simple messages, not exceptions with stack trace.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Scala,
    Java,
    style guides.
  • All code has been tested:
    • Manually tested

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 12, 2024
@JaroslavTulach JaroslavTulach self-assigned this Feb 12, 2024
@JaroslavTulach
Copy link
Member Author

Running Unbooked_Seats.zip:

sbt:enso> runEngineDistribution --run /tmp/Unbooked_Seats
...
[WARN] [2024-02-12T07:16:54+01:00] [enso.org.enso.interpreter.runtime.SerializationPool] Serialization of module `local.Unbooked_Seats.Main` failed: No persistance for org.enso.compiler.core.ir.expression.warnings.Shadowed$FunctionParam`
[success] Total time: 23 s, completed Feb 12, 2024, 7:16:58 AM

produces just a WARNING message without any stacktrace.

@JaroslavTulach
Copy link
Member Author

A note about not serializing warnings:

don't want to persist files with errors ... probably don't want to persist even files with warnings

As such this PR doesn't do anything with persistance. It only changes the logging.

@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Feb 12, 2024
@JaroslavTulach JaroslavTulach added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Feb 12, 2024
@JaroslavTulach JaroslavTulach added the CI: Keep up to date Automatically update this PR to the latest develop. label Feb 13, 2024
@JaroslavTulach JaroslavTulach removed the CI: Keep up to date Automatically update this PR to the latest develop. label Feb 13, 2024
@JaroslavTulach
Copy link
Member Author

Looks like

fixed a problem! While previously the Windows build was constantly failing. Now, after merge with develop it succeeded at first run. Or we are just lucky this time...

@mergify mergify bot merged commit 04161b3 into develop Feb 13, 2024
25 of 27 checks passed
@mergify mergify bot deleted the wip/jtulach/NoStackTrace_8896 branch February 13, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No persistance for Shadowed$FunctionParam.
3 participants