Merge empty_error #9000
Merged
Merge empty_error #9000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdRiley
added
the
CI: No changelog needed
AdRiley
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
4e6,
JaroslavTulach,
hubertp and
Akirathan
as code owners
GregoryTravis
approved these changes
Feb 7, 2024
jdunkerley
approved these changes
Feb 7, 2024
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Statistics.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/Errors/Empty_Error.enso
Outdated
Show resolved
Hide resolved
Akirathan
approved these changes
Feb 8, 2024
AdRiley
force-pushed
the
wip/adr/merge-empty-errors
branch
from
8981b53 to
1091260
Compare
radeusgd
reviewed
Feb 9, 2024
distribution/lib/Standard/Base/0.0.0-dev/src/Errors/Empty_Error.enso
Outdated
Show resolved
Hide resolved
radeusgd
approved these changes
Feb 9, 2024
AdRiley
force-pushed
the
wip/adr/merge-empty-errors
branch
from
3ed2983 to
3769c95
Compare
4e6
approved these changes
Feb 9, 2024
radeusgd
reviewed
Feb 10, 2024
| @@ -710,7 +710,7 @@ type Array | |||
|
|
|||
| [0, 1, 2].to_array . reduce (+) | |||
| reduce : (Any -> Any -> Any) -> Any -> Any | |||
| reduce self function ~if_empty=(Error.throw Empty_Error) = Vector.reduce self function if_empty | |||
| reduce self function ~if_empty=(Error.throw (Empty_Error.Error Vector)) = Vector.reduce self function if_empty | |||
There was a problem hiding this comment.
Shouldn't this be
Suggested change
| reduce self function ~if_empty=(Error.throw (Empty_Error.Error Vector)) = Vector.reduce self function if_empty | |
| reduce self function ~if_empty=(Error.throw (Empty_Error.Error Array)) = Vector.reduce self function if_empty |
given that we are operating with an Array here??
I know they are pretty much interchangeable but they still are separate types.
(Sorry I just noticed it after getting a merge conflict with #8867)
There was a problem hiding this comment.
Yes. Good spot :) I will change that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
We don't need 3 copies of empty_error. This PR makes them one.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.